Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell.packages.ghc881.unordered-containers: remove broken override #67650

Closed
wants to merge 1 commit into from
Closed

haskell.packages.ghc881.unordered-containers: remove broken override #67650

wants to merge 1 commit into from

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Aug 28, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vaibhavsagar vaibhavsagar changed the title ghc881: remove broken unordered-containers override haskell.packages.ghc881.unordered-containers: remove broken override Aug 28, 2019
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.packages.ghc881.unordered-containers

@cdepillabout
Copy link
Member

@vaibhavsagar Should this PR and your other recent PRs (#67651, #67653, #67654, #67655, and #67657) be based on the haskell-updates branch instead of master?

@infinisil recently left a comment explaining that any change to the configuration-*.nix files should probably go to the haskell-updates branch.

@vaibhavsagar
Copy link
Member Author

Closed in favour of #67709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vaibhavsagar @cdepillabout