arx-libertatis: 2019-02-16 -> 2019-07-22 #67806
Conversation
There was a problem hiding this comment.
We shouldn't make any references to qt5, and instead use libsForQt5.callPackage in all-packages.nix and use qt's specific deriver mkDerivation. See latest qt documentation.
We also don't need to add wrapQtAppsHook to nativeBuildInputs as the deriver adds it automatically.
|
|
||
| postInstall = '' | ||
| ln -sf \ | ||
| ${dejavu_fonts}/share/fonts/truetype/DejaVuSansMono.ttf \ | ||
| $out/share/games/arx/misc/dejavusansmono.ttf | ||
| '' + optionalString withCrashReporter '' | ||
| wrapQtApp "$out/libexec/arxcrashreporter" |
There was a problem hiding this comment.
Binaries in libexec should be automatically wrapped.
Is this a script?
There was a problem hiding this comment.
No, but I had to disable the wrapping by default since it was acting on other unrelated binaries: only the crash reporter is a Qt application.
I read the documentation but this is not a Qt application or library. |
I see, though the bit excluding using |
|
We need to use |
Ok, I understand. Is this ok, now? |
|
backported in 851b51f |
|
Thank you! |
Motivation for this change
The crash reporter needs wrapping (#65399). The package also needs its usual update before the 19.09 release.
Things done
nix path-info -Sbefore and after)Btw, here's proof the crash reported is working:
