Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/bash: Improve Emacs detection for PS1 #67728

Conversation

vikanezrimaya
Copy link
Member

Motivation for this change

That's one of my itches - when I'm sshing from Emacs' term to a NixOS machine, it doesn't detect that I'm running emacs and showing a title escape sequence. This commit fixes it, checking against $TERM to prevent this from ever bothering anyone again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Tested in production 馃樅
Notify maintainers

Wasn't able to find anyone, sorry!

That's one of my itches - when I'm sshing from Emacs' term to a NixOS
machine, it doesn't detect that I'm running emacs and showing a title
escape sequence. This commit fixes it, checking against $TERM to
prevent this from ever bothering anyone again.
@matthewbauer
Copy link
Member

This is probably safe, but I'm a little bit surprised it is necessary. I thought INSIDE_EMACS would always be set in these cases?

@vikanezrimaya
Copy link
Member Author

Nope, it's not passed via ssh. And I'm doing a lot of ssh-ing, especially with Nixops. Roughly half of machines I work with are headless...

@matthewbauer
Copy link
Member

Ah yeah makes sense. There is some config that forwards it, but I think TERM is always forwarded.

@matthewbauer matthewbauer merged commit c2ef4fd into NixOS:master Aug 29, 2019
@vikanezrimaya vikanezrimaya deleted the bash-module-emacs-eterm-remote-prompt-fix branch August 29, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants