electrum: update for the Qt5 change (#65399) #67727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepfire
force-pushed
the
serge/electrum
branch
2 times, most recently
from
c5fa22f
to
8053c68
Compare
deepfire
changed the title
deepfire
changed the title
joachifm
reviewed
Aug 30, 2019
deepfire
force-pushed
the
serge/electrum
branch
from
8053c68
to
e568ff5
Compare
| @@ -102,7 +104,8 @@ python3Packages.buildPythonApplication rec { | |||
| "Exec=$out/bin/electrum %u" \ | |||
| --replace 'Exec=sh -c "PATH=\"\\$HOME/.local/bin:\\$PATH\"; electrum --testnet %u"' \ | |||
| "Exec=$out/bin/electrum --testnet %u" | |||
| ''; | |||
|
|
|||
| '' + (if enableQt then "wrapQtApp $out/bin/electrum" else ""); | |||
There was a problem hiding this comment.
I think this should really happen in the postFixup phase
postFixup = lib.optionalString enableQt ''
wrapQtApp $out/bin/electrum
'';
e568ff5
to
da39cb1
Compare
deepfire
force-pushed
the
serge/electrum
branch
from
da39cb1
to
3d5144a
Compare
worldofpeace
approved these changes
Sep 1, 2019
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
electrum, in line with the Qt update (#65399).Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @ehmry @joachifm