Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fly: 5.3.0 -> 5.4.1 #67633

Merged
merged 1 commit into from Aug 28, 2019
Merged

fly: 5.3.0 -> 5.4.1 #67633

merged 1 commit into from Aug 28, 2019

Conversation

imuli
Copy link
Contributor

@imuli imuli commented Aug 28, 2019

Motivation for this change

Version bump. (5.3 askes to upgrade when faced with 5.4 servers.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @ivanbrennan

@imuli imuli changed the title fly: bump to 5.4.1 fly: 5.3.0 -> 5.4.1 Aug 28, 2019
ivanbrennan
ivanbrennan approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@ivanbrennan ivanbrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether I have the authority to merge PRs to upstream, but this looks good to me.

@ofborg ofborg bot requested a review from kalbasit August 28, 2019 16:04
jonringer
jonringer approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary seems to work
leaf package

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67633
1 package were build:
fly

@kalbasit
Copy link
Member

@GrahamcOfBorg build fly

@kalbasit kalbasit merged commit 7863697 into NixOS:master Aug 28, 2019
@jonringer
Copy link
Contributor

I'm not sure whether I have the authority to merge PRs to upstream, but this looks good to me.

There's talk of enabling this through ofBorg for leaf packages such as this, but it's still in discussion.

@imuli imuli deleted the updated-fly branch August 29, 2019 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@ivanbrennan ivanbrennan ivanbrennan approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@imuli @kalbasit @jonringer @ivanbrennan