ariang: init at 1.1.3 #67616
Closed
ariang: init at 1.1.3 #67616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
reviewed
Aug 28, 2019
| { stdenv, fetchurl, unzip }: | ||
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "ariang-${version}"; |
There was a problem hiding this comment.
Suggested change
| name = "ariang-${version}"; | |
| pname = "ariang"; |
I use it like this: services.nginx.virtualHosts."aria2.${domain}" = {
root = "${pkgs.ariang}";
}; |
jonringer
reviewed
Aug 28, 2019
| sourceRoot = "."; | ||
| buildInputs = [ unzip ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Since you're just fetching a zip, i would convert this over to a fetchzip derivation such as:
{ lib, fetchzip }:
let
version = "1.1.3";
in
fetchzip rec {
name = "ariang-${version}";
url = "https://github.com/mayswind/AriaNg/releases/download/${version}/AriaNg-${version}.zip";
sha256 = "0s9wmrq2fv1bf5ngw8w9ld1q8i3s07rsq8qm102z6jvxpjm9bl1v";
meta = with lib; {
description = "Modern web frontend making aria2 easier to use";
license = licenses.mit;
homepage = "http://ariang.mayswind.net/";
maintainers = with maintainers; [ dawidsowa ];
};
}
the real savings is in the closure size:
$ nix path-info -Sh ./results/ariang
/nix/store/3pq759vrz0lng62r95c57f5jcsiqqm2s-ariang-1.1.3 220.2M
$ nix path-info -Sh ./result
/nix/store/nxmk3ibd4dmqy9h8chp0hqrqpcq11n0s-ariang-1.1.3 2.5M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added AriaNG web app.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @