Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcc: init at 5.5.1 #67617

Merged
merged 1 commit into from Sep 17, 2019
Merged

kcc: init at 5.5.1 #67617

merged 1 commit into from Sep 17, 2019

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

Added Kindle Comic Converter

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jtojnar
Copy link
Contributor

jtojnar commented Aug 28, 2019

Is wrapQtAppsHook necessary with mkDerivationWith?

@jtojnar
Copy link
Contributor

jtojnar commented Aug 28, 2019 •
edited

I am getting a warning about missing kindlegen. Could you add that thing to PATH too? Edit: or maybe not, that one is unfree.

jonringer
jonringer reviewed Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the mixed signals, didn't see the libsForQt5.callPackage when i first reviewed.

pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
pkgs/applications/graphics/kcc/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

Is wrapQtAppsHook necessary with mkDerivationWith?

It's not, that was my bad :(. Updated review.

@dawidsowa
Copy link
Contributor Author

dawidsowa commented Aug 28, 2019 •
edited

Sorry for the mixed signals, didn't see the libsForQt5.callPackage when i first reviewed.

It's because I changed it from python3Packages.callPackage.

@jtojnar jtojnar merged commit be4606d into NixOS:master Sep 17, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2019

Thank you.

@dawidsowa dawidsowa deleted the kcc branch October 11, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidsowa @jtojnar @jonringer