Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neofetch: 6.0.0 -> 6.1.0 #67811

Merged
merged 1 commit into from Aug 31, 2019
Merged

neofetch: 6.0.0 -> 6.1.0 #67811

merged 1 commit into from Aug 31, 2019

Conversation

tadeokondrak
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from konimex and alistairbill August 31, 2019 05:44
dywedir
dywedir reviewed Aug 31, 2019
View reviewed changes
pkgs/tools/misc/neofetch/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/neofetch/default.nix Outdated Show resolved Hide resolved
@dywedir
Copy link
Member

dywedir commented Aug 31, 2019

@GrahamcOfBorg build neofetch

jonringer
jonringer approved these changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
binary works (It's needlessly wonderful, I love it)
leaf package

https://github.com/NixOS/nixpkgs/pull/67811
1 package were build:
neofetch

@dywedir
Copy link
Member

dywedir commented Aug 31, 2019

Thanks!

@dywedir dywedir merged commit a5ba6ba into NixOS:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir left review comments

@jonringer jonringer jonringer approved these changes

@konimex konimex Awaiting requested review from konimex

@alistairbill alistairbill Awaiting requested review from alistairbill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tadeokondrak @dywedir @jonringer