Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-watch: init at 7.2.1 #67815

Merged
merged 1 commit into from Sep 1, 2019
Merged

cargo-watch: init at 7.2.1 #67815

merged 1 commit into from Sep 1, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Aug 31, 2019

Motivation for this change

A Cargo subcommand for watching over Cargo project's source

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

@GrahamcOfBorg build cargo-watch

ivan
ivan approved these changes Sep 1, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested on NixOS x86_64, cargo watch seems to work fine.

LGTM even without the darwin support, which could be added later.

@mmahut mmahut merged commit 05fbc57 into NixOS:master Sep 1, 2019
@xrelkd xrelkd deleted the add/cargo-watch branch September 1, 2019 06:55
@xrelkd
Copy link
Contributor Author

xrelkd commented Sep 1, 2019

@mmahut @ivan Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xrelkd @mmahut @ivan