Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nfs-utils: 2.3.4 -> 2.4.1 #67741

Merged
merged 1 commit into from Aug 30, 2019
Merged

nfs-utils: 2.3.4 -> 2.4.1 #67741

merged 1 commit into from Aug 30, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @abbradar

@ofborg ofborg bot requested a review from abbradar August 30, 2019 02:33
@markuskowa
Copy link
Member

markuskowa commented Aug 30, 2019 •
edited

@GrahamcOfBorg build nfs-utils
@GrahamcOfBorg test nfs

@markuskowa markuskowa self-assigned this Aug 30, 2019
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg test nfs3 nfs4

@mmahut mmahut merged commit fd01dc5 into NixOS:master Aug 30, 2019
@averelld averelld deleted the nfs-utils-upgrade branch August 30, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees

@markuskowa markuskowa

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @markuskowa @mmahut