Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robo3t: 1.1.1 -> 1.3.1 #67745

Merged
merged 1 commit into from Aug 30, 2019
Merged

robo3t: 1.1.1 -> 1.3.1 #67745

merged 1 commit into from Aug 30, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @emanueleperuffo

@ofborg ofborg bot requested a review from emanueleperuffo August 30, 2019 03:40
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build robo3t

@mmahut mmahut merged commit f1f50c1 into NixOS:master Aug 30, 2019
@averelld averelld deleted the robo3t-upgrade branch August 30, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emanueleperuffo emanueleperuffo emanueleperuffo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @mmahut @emanueleperuffo