Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roxterm: 3.3.2 -> 3.7.5 #67807

Merged
merged 1 commit into from Sep 3, 2019
Merged

roxterm: 3.3.2 -> 3.7.5 #67807

merged 1 commit into from Sep 3, 2019

Conversation

cdepillabout
Copy link
Member

Motivation for this change

Update roxterm to the latest version.

This changes from the old, unmaintained version on Sorceforge to the new version on Github. The build has been changed to use cmake, so the build steps are simpler.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cmake-multiple-definitions-when-linking/3872/4

disassembler
disassembler approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@disassembler disassembler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor request to use fetchFromGitHub instead of fetchgit

pkgs/applications/misc/roxterm/default.nix Outdated Show resolved Hide resolved
@cdepillabout
Copy link
Member Author

@GrahamcOfBorg build roxterm

@aristidb aristidb merged commit 15a461d into NixOS:master Sep 3, 2019
@cdepillabout cdepillabout deleted the update-roxterm branch September 3, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan left review comments

@mmahut mmahut mmahut left review comments

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cdepillabout @nixos-discourse @ivan @mmahut @disassembler @aristidb