Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fwupd: add package option #67702

Merged
merged 1 commit into from Aug 30, 2019
Merged

nixos/fwupd: add package option #67702

merged 1 commit into from Aug 30, 2019

Conversation

mweinelt
Copy link
Member

Motivation for this change

Allow overriding the package used in the fwupd module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill @worldofpeace @jtojnar

@mweinelt
Copy link
Member Author

@worldofpeace Ah not sure how notifications work on pulls, but I force-pushed changes.

@worldofpeace
Copy link
Contributor

These options are kinda a subject of debate (#50476), but as you've contributed the change you'd at least have some use for this.

@worldofpeace
Copy link
Contributor

@worldofpeace Ah not sure how notifications work on pulls, but I force-pushed changes.

Thanks, sometimes github can't decide to send a notification when someone force pushes 😄
So that actually helps sometimes.

@worldofpeace worldofpeace merged commit da456af into NixOS:master Aug 30, 2019
@mweinelt mweinelt deleted the pr/fwupd-cfg.package branch February 24, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @worldofpeace