Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sayonara: 1.1.1 -> 1.5.1 #67603

Merged
merged 1 commit into from
Sep 4, 2019
Merged

sayonara: 1.1.1 -> 1.5.1 #67603

merged 1 commit into from
Sep 4, 2019
+72 −36

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular update that uses the fixed taglib.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @deepfire

Sorry, something went wrong.

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Aug 28, 2019
@ofborg ofborg bot requested a review from ttuegel August 28, 2019 08:06
deepfire
deepfire approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@peterhoeg
Copy link
Member Author

I shifted the taglib change to a separate PR that targets staging.

@peterhoeg
Copy link
Member Author

@GrahamcOfBorg build sayonara

@ofborg ofborg bot requested a review from deepfire September 4, 2019 06:53
@peterhoeg peterhoeg merged commit afa6c91 into NixOS:master Sep 4, 2019
@peterhoeg peterhoeg deleted the u/sayonara branch September 4, 2019 07:41
@peterhoeg peterhoeg restored the u/sayonara branch September 5, 2019 01:17
@peterhoeg peterhoeg deleted the u/sayonara branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the u/sayonara branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the u/sayonara branch September 24, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel

@deepfire deepfire

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @deepfire