verifpal: init at 0.2 #67607
verifpal: init at 0.2 #67607
Conversation
zimbatm
added
the
6.topic: NLNet / NGI
| }; | ||
|
|
||
| postPatch = '' | ||
| sed -e 's|/bin/echo|echo|g' -i Makefile |
There was a problem hiding this comment.
would it be neater to use a patch here? perhaps even patchShebangs would work
There was a problem hiding this comment.
the Makefile has a lot of @/bin/echo "Some message" lines. This will be more resilient to change when upstream adds more directives. I will make it even more resilient like this:
- sed -e 's|/bin/echo|echo|g' -i Makefile
+ sed -e 's|/bin/echo |echo |g' -i MakefilepatchShebangs only works on the first line of the scripts
| sha256 = "1n0zqidwbqqfslrirpbqw14ylgiry6ggcp9ll4h8rf1chqwk6dhv"; | ||
| }; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
would this be neater with meta = with lib; {
There was a problem hiding this comment.
I am trying to limit the scope of with as much as possible since it creates implicit dependencies. Also it would save 8 characters below and adds 10 characters.
There was a problem hiding this comment.
Fair enough, I was just going off of what is usually done
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Motivation for this change
Done for the NLNet PET program
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @