Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcompris: use Qt mkDerivation #67604

Merged
merged 1 commit into from Aug 29, 2019
Merged

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Part of the move to use Qt's mkDerivation.

Also ran nixpkgs-fmt on it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @guibou

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, verified it was wrapped.

@worldofpeace worldofpeace merged commit bde1c6b into NixOS:master Aug 29, 2019
@ofborg ofborg bot requested a review from guibou August 29, 2019 02:35
@peterhoeg peterhoeg deleted the f/gcompris branch August 29, 2019 06:19
@peterhoeg peterhoeg restored the f/gcompris branch August 29, 2019 08:28
@peterhoeg peterhoeg deleted the f/gcompris branch September 13, 2019 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants