strawberry: init at 0.6.3 #67605

peterhoeg · 2019-08-28T07:59:52Z

Motivation for this change

strawberry is a maintained fork of clementine. Can highly recommend it.

Things done

Notify maintainers

cc @ttuegel as clementine maintainer

alexarice · 2019-08-28T08:43:38Z

pkgs/applications/audio/strawberry/default.nix

@@ -0,0 +1,45 @@
+{ mkDerivation, stdenv, lib, fetchFromGitHub, cmake, pkgconfig
+, alsaLib, boost, chromaprint, fftw, gnutls, libcdio, libmtp, libpthreadstubs, libtasn1, libXdmcp, pcre, protobuf, sqlite, taglib


This line is quite long, could it be split into two?

I've just run nixpkgs-fmt on it to clean things up.

I wasn't aware nixpkgs-fmt was released yet.

It's in unstable.

alexarice · 2019-08-28T08:44:06Z

pkgs/applications/audio/strawberry/default.nix

@@ -0,0 +1,45 @@
+{ mkDerivation, stdenv, lib, fetchFromGitHub, cmake, pkgconfig


I've never seen mkDerivation as a function arg but I guess it makes sense

Though this does mean stdenv has not been used anywhere

See #65399.

stdenv is used in stdenv.isLinux.

of course, my bad

Thanks for the link as well

alexarice · 2019-08-28T08:44:57Z

pkgs/applications/audio/strawberry/default.nix

+  };
+
+  buildInputs = [
+    alsaLib boost chromaprint fftw gnutls libcdio libmtp libpthreadstubs libtasn1 libXdmcp pcre protobuf sqlite taglib


this line is also quite long

alexarice · 2019-08-28T08:45:31Z

pkgs/applications/audio/strawberry/default.nix

+    qtbase qtx11extras
+  ] ++ lib.optionals stdenv.isLinux [
+    libpulseaudio libselinux libsepol p11_kit utillinux
+  ] ++ lib.optionals withVlc [


lib.optional withVlc vlc would work here

alexarice · 2019-08-28T09:11:57Z

I would run nix-review but it's trying to run a mass rebuild so I might try again when nixpkgs moves forwards

worldofpeace · 2019-08-28T13:40:13Z

I would run nix-review but it's trying to run a mass rebuild so I might try again when nixpkgs moves forwards

This touches taglib so it's likely you have to rebuild gstreamer.

alexarice · 2019-08-30T10:18:41Z

I gave nix-review another try but I think it'd take all day on my laptop.

While running it I did get the following errors though they don't seem related to this package so I'm a bit confused.

builder for '/nix/store/7sfljq22sax1spzlh1jk2kpkzy5s8ncf-breeze-qt5-5.15.5.drv' failed with exit code 2; last 10 log lines:
  Scanning dependencies of target breeze-settings5
  [ 10%] Building CXX object kstyle/config/CMakeFiles/breeze-settings5.dir/breeze-settings5_autogen/mocs_compilation.cpp.o
  [ 11%] Building CXX object kstyle/config/CMakeFiles/breeze-settings5.dir/main.cpp.o
  [ 12%] Linking CXX executable breeze-settings5
  /nix/store/mgdjnsrkqgmxqjaqaxgqyqm7fwyi96fk-binutils-2.31.1/bin/ld: /nix/store/s7fyj3h4z4h5r7mlwzhdvpk89kjmx785-kservice-5.58.0/lib/libKF5Service.so.5.58.0: undefined reference to `qt_version_tag@Qt_5.12'
  /nix/store/mgdjnsrkqgmxqjaqaxgqyqm7fwyi96fk-binutils-2.31.1/bin/ld: /nix/store/pll7y62wa1xzzvmhpjkd5jvjz2r2jqw2-kwidgetsaddons-5.58.0/lib/libKF5WidgetsAddons.so.5.58.0: undefined reference to `QCoreApplication::sendEvent(QObject*, QEvent*)@Qt_5'
  collect2: error: ld returned 1 exit status
  make[2]: *** [kstyle/config/CMakeFiles/breeze-settings5.dir/build.make:99: kstyle/config/breeze-settings5] Error 1
  make[1]: *** [CMakeFiles/Makefile2:645: kstyle/config/CMakeFiles/breeze-settings5.dir/all] Error 2
  make: *** [Makefile:130: all] Error 2
cannot build derivation '/nix/store/a7zm7zd5id30fk0spchqva8cxa0dgczn-kwin-5.15.5.drv': 1 dependencies couldn't be built
builder for '/nix/store/jx9z3sjln4aqb9n28ga6sq6n6qbl5625-python2.7-cheroot-6.5.6.drv' failed with exit code 1; last 10 log lines:
  0.98s teardown cheroot/test/test_ssl.py::test_tls_client_auth[0-True-localhost-pyopenssl]
  =========================== short test summary info ============================
  XFAIL cheroot/test/test_conn.py::test_Chunked_Encoding
    Server does not correctly read trailers/ending of the previous HTTP request, thus the second request fails as the server tries to parse b'Content-Type: application/json\r\n' as a Request-Line. This results in HTTP status code 400, instead of 413Ref: https://github.com/cherrypy/cheroot/issues/69
  XFAIL cheroot/test/test_conn.py::test_598
    Sometimes this test fails due to low timeout. Ref: https://github.com/cherrypy/cherrypy/issues/598
  XFAIL cheroot/test/test_core.py::test_parse_uri_unsafe_uri
    Fails on Python 2
  SKIPPED [1] cheroot/test/test_server.py:117: Abstract sockets don't work currently
  ==== 4 failed, 99 passed, 1 skipped, 3 xfailed, 1 warnings in 83.86 seconds ====
cannot build derivation '/nix/store/070040jmxzm7xby779bzs5xq9g8vcfd8-python2.7-cherrypy-17.4.2.drv': 1 dependencies couldn't be built

Further, is it really correct that this package has 4 different versions of gst_plugins_good and evince in its dependencies?

peterhoeg · 2019-08-30T11:29:06Z

We should probably move that taglib change to staging instead.

peterhoeg · 2019-09-04T06:41:50Z

And here it is without the taglib change which is in its own PR.

peterhoeg · 2019-09-04T06:42:00Z

@GrahamcOfBorg build strawberry

ofborg bot added the 8.has: package (new) label Aug 28, 2019

ofborg bot requested a review from ttuegel August 28, 2019 08:14

ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Aug 28, 2019

alexarice reviewed Aug 28, 2019

View reviewed changes

peterhoeg added 2 commits September 4, 2019 14:39

taglib: fix ogg file corruption

db9c11d

strawberry: init at 0.6.3

5a12e12

peterhoeg force-pushed the p/strawberry branch from 747f424 to 5a12e12 Compare September 4, 2019 06:40

ofborg bot added 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 labels Sep 4, 2019

peterhoeg merged commit ac9b16d into NixOS:master Sep 4, 2019

peterhoeg deleted the p/strawberry branch September 4, 2019 07:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

strawberry: init at 0.6.3 #67605

strawberry: init at 0.6.3 #67605

peterhoeg commented Aug 28, 2019

alexarice Aug 28, 2019

peterhoeg Aug 28, 2019

alexarice Aug 28, 2019

peterhoeg Aug 29, 2019

alexarice Aug 28, 2019

alexarice Aug 28, 2019

peterhoeg Aug 28, 2019

alexarice Aug 28, 2019

alexarice Aug 28, 2019

alexarice Aug 28, 2019

alexarice Aug 28, 2019

peterhoeg Aug 28, 2019

alexarice commented Aug 28, 2019

worldofpeace commented Aug 28, 2019

alexarice commented Aug 30, 2019

peterhoeg commented Aug 30, 2019

peterhoeg commented Sep 4, 2019

peterhoeg commented Sep 4, 2019

		@@ -0,0 +1,45 @@
		{ mkDerivation, stdenv, lib, fetchFromGitHub, cmake, pkgconfig
		, alsaLib, boost, chromaprint, fftw, gnutls, libcdio, libmtp, libpthreadstubs, libtasn1, libXdmcp, pcre, protobuf, sqlite, taglib

strawberry: init at 0.6.3 #67605

strawberry: init at 0.6.3 #67605

Conversation

peterhoeg commented Aug 28, 2019

Motivation for this change

Things done

Notify maintainers

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexarice commented Aug 28, 2019

worldofpeace commented Aug 28, 2019

alexarice commented Aug 30, 2019

peterhoeg commented Aug 30, 2019

peterhoeg commented Sep 4, 2019

peterhoeg commented Sep 4, 2019