Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresqlPackages.plv8: 2.3.12 -> 2.3.13 #67600

Merged
merged 3 commits into from Aug 31, 2019
Merged

postgresqlPackages.plv8: 2.3.12 -> 2.3.13 #67600

merged 3 commits into from Aug 31, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 28, 2019

Motivation for this change

Changes: plv8/plv8@v2.3.12...v2.3.13

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from volth August 28, 2019 04:16
@mmahut
Copy link
Member

mmahut commented Aug 28, 2019

Fails on aarch64.

unpacking sources
unpacking source archive /nix/store/1g1akgzq8jwzsdbhy108vpyvv99g567w-source
source root is source
patching sources
patching script interpreter paths in tools/dev/v8gen.py
tools/dev/v8gen.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/xml30xvd7xbv98v6ciivd3yi71frh2cf-python-2.7.16/bin/python"
updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./third_party/icu/source/config.sub
cp: cannot remove './third_party/icu/source/config.sub': Permission denied
builder for '/nix/store/xmx42427h48y4jhvlvi9m33p6haqx06k-v8-6.4.388.40.drv' failed with exit code 1
cannot build derivation '/nix/store/jk8gf1aq87ir6yb1c7bxllvhmbasd5ml-plv8-2.3.13.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jk8gf1aq87ir6yb1c7bxllvhmbasd5ml-plv8-2.3.13.drv' failed```

@marsam
postgresqlPackages.plv8: narrow platforms to x86_64-linux
f24c729 
plv8 uses a custom version v8 version, which is reported to only build
on x86_64-linux. The next major version plv8 should drop the custom v8.
@marsam
postgresqlPackages.plv8: add marsam as maintainer
964974b
@marsam
Copy link
Contributor Author

marsam commented Aug 29, 2019

@mmahut thanks for testing, I've narrowed plv8's platforms to x86_64-linux

@mmahut
Copy link
Member

mmahut commented Aug 29, 2019

@GrahamcOfBorg build postgresqlPackages.plv8

@marsam marsam merged commit 4e24cf1 into NixOS:master Aug 31, 2019
@marsam marsam deleted the update-plv8 branch August 31, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @mmahut