Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fetchurlBoot: remove cycles introduced by openssl_1_1 -> coreutils #67784

Merged
merged 1 commit into from Sep 2, 2019
Merged

fetchurlBoot: remove cycles introduced by openssl_1_1 -> coreutils #67784

merged 1 commit into from Sep 2, 2019

Conversation

dylex
Copy link
Contributor

@dylex dylex commented Aug 30, 2019

Motivation for this change

Along the same lines as #58283, the change to openssl_1_1 in c18167c introduced a dependency cycle from fetchurl -> curl -> openssl -> coreutills -> ... -> fetchurl. This breaks these cycles. (However, the dependency on coreutils itself is only for a /bin/env reference, so there may be a simpler way to remove this.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @matthewbauer

@dylex
Copy link
Contributor Author

dylex commented Aug 30, 2019

Actually, while this solves the recursive dependencies, I'm seeing some possible problems with the openssl build itself in this boot case. Maybe hold off for a bit.

@FRidh FRidh added this to the 19.09 milestone Aug 30, 2019
@dylex
Copy link
Contributor Author

dylex commented Aug 30, 2019

I rebased and did some more testing and I think this is all good now.

@disassembler disassembler merged commit 363292b into NixOS:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dylex @disassembler @FRidh