Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackage.nixpart0: disable for python3 #67665

Merged
merged 1 commit into from Aug 30, 2019
Merged

pythonPackage.nixpart0: disable for python3 #67665

merged 1 commit into from Aug 30, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

noticed it was failling to build when reviewing #67658

python2Packages.nixpart0 still builds fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig

@teto teto mentioned this pull request Aug 29, 2019
Closed
@ofborg ofborg bot requested a review from aszlig August 29, 2019 06:41
@teto
Copy link
Member

teto commented Aug 29, 2019

@GrahamcOfBorg build nixpart0

aszlig
aszlig approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@aszlig aszlig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the wrong homepage URL, it's fine. Thanks :-)

pkgs/tools/filesystems/nixpart/0.4/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor Author

@aszlig @teto it's now morning :)

@ofborg ofborg bot requested a review from aszlig August 29, 2019 17:32
@teto
Copy link
Member

teto commented Aug 30, 2019

good morning ?! :p

@teto
Copy link
Member

teto commented Aug 30, 2019

@GrahamcOfBorg build nixpart0

@teto
Copy link
Member

teto commented Aug 30, 2019

@GrahamcOfBorg build pythonPackages.nixpart0

@teto
Copy link
Member

teto commented Aug 30, 2019

should the https://logs.nix.ci/?key=nixos/nixpkgs.67665&attempt_id=9c7025c3-4d30-46b6-bca2-eafe28a814f8 be considered blocking ?

@jonringer
Copy link
Contributor Author

I would say no, the purpose of the PR is to prevent the python3Package.nixpart0 from attempting to build. if someone wants to fix the aarch64 build of multipath-tools, then that would be the concern of a differnt issue/PR.

@teto teto merged commit 5fe68fd into NixOS:master Aug 30, 2019
@jonringer jonringer deleted the mark-nixpart0-py-disabled branch August 30, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@aszlig aszlig Awaiting requested review from aszlig

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @teto @aszlig