mpv, ffmpeg: use addOpenGLRunpath to fix CUDA-accelerated playback #67790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build mpv |
matthewbauer
added a commit
to matthewbauer/nixpkgs
that referenced
this pull request
Aug 30, 2019
Unfortunately there are still a few programs that need this. To avoid breaking too many things for the 19.09 release, I recommend making this true. We can disable it again once we feel confident most of these cases are handled. Relevant issues: - NixOS#67790 - NixOS#66544 - https://discourse.nixos.org/t/getting-an-error-has-anything-regarding-opengl-in-nixpkgs/3641 /cc @ambrop72 @disassembler @lheckemann
10 tasks
10 tasks
This fixes NixOS#67780. Currently, using `mpv --hwdec=nvdec --msg-level=vd=debug` on NVIDIA results in: ``` [vd] Opening decoder hevc [vd] Looking at hwdec hevc-nvdec... Cannot load libcuda.so.1 [vd] Could not create device. [vd] No hardware decoding available for this codec. ``` With just mpv patched, ffmpeg cannot load libnvcuvid.so.1: ``` [vd] Opening decoder hevc [vd] Looking at hwdec hevc-nvdec... [vd] Trying hardware decoding via hevc-nvdec. [vd] Selected codec: hevc (HEVC (High Efficiency Video Coding)) [vd] Pixel formats supported by decoder: vaapi_vld cuda yuv420p10le [vd] Codec profile: Main 10 (0x2) [vd] Requesting pixfmt 'cuda' from decoder. [ffmpeg/video] hevc: Cannot load libnvcuvid.so.1 [ffmpeg/video] hevc: Failed loading nvcuvid. [ffmpeg/video] hevc: Failed setup for format cuda: hwaccel initialisation returned error. ``` With both mpv and ffmpeg patched, it works: ``` [vd] Opening decoder hevc [vd] Looking at hwdec hevc-nvdec... [vd] Trying hardware decoding via hevc-nvdec. [vd] Selected codec: hevc (HEVC (High Efficiency Video Coding)) [vd] Pixel formats supported by decoder: vaapi_vld cuda yuv420p10le [vd] Codec profile: Main 10 (0x2) [vd] Requesting pixfmt 'cuda' from decoder. Using hardware decoding (nvdec). [vd] Decoder format: 3840x2160 cuda[p010] bt.2020-ncl/bt.2020/pq/limited/auto SP=10.000000 CL=unknown (auto 0.000000/0.000000/0.000000) ```
ivan
force-pushed
the
mpv-ffmpeg-runpath
branch
from
261134c
to
46cbb84
Compare
|
Updated to sort the nativeBuildInputs. |
|
@GrahamcOfBorg build mpv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes #67780.
Currently, using
mpv --hwdec=nvdec --msg-level=vd=debug ...on NVIDIA results in:With just mpv patched, ffmpeg cannot load libnvcuvid.so.1:
With both mpv and ffmpeg patched, it works:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)I tested a very similar commit on master, not staging.
Notify maintainers
mpv: cc @AndersonTorres @Fuuzetsu @fpletz @globin
ffmpeg: cc @codyopel @Fuuzetsu