Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.sfepy: init at 2019.2 #67788

Merged
merged 1 commit into from
Feb 9, 2020
Merged

pythonPackages.sfepy: init at 2019.2 #67788

merged 1 commit into from
Feb 9, 2020

Conversation

wd15
Copy link
Contributor

@wd15 wd15 commented Aug 30, 2019

Add Sfepy finite element solver.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@wd15 wd15 requested a review from FRidh as a code owner August 30, 2019 20:09
@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 30, 2019
@wd15 wd15 changed the title pythonPackages.sfepy: init at 2019.2 [WIP] pythonPackages.sfepy: init at 2019.2 Sep 1, 2019
@wd15 wd15 changed the title [WIP] pythonPackages.sfepy: init at 2019.2 pythonPackages.sfepy: init at 2019.2 Sep 2, 2019
@wd15
Copy link
Contributor Author

wd15 commented Sep 5, 2019

@risicle, all your suggested changes have been included now.

@wd15 wd15 requested a review from risicle September 5, 2019 21:08
@risicle
Copy link
Contributor

risicle commented Sep 6, 2019

Hmm. The tests seem to be taking a lot longer than they were previously for me. I wonder if it would be better to blacklist a few of the worst offenders by adding them to the rm list.

@wd15
Copy link
Contributor Author

wd15 commented Sep 7, 2019

I filed an issue with the Sfepy developer regarding having a --fast option for the tests, but in the meantime I removed the slowest ones so we can move forward with this. The tests run in ~20s now for me.

@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

Cool. For some reason test_splinebox.py fails for me now under py27/macos 10.13. Investigating, because it's fine on linux and also on py37...

@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

Ok, the problem seems to be a fairly standard matplotlib/macos one that can be solved with a modification to the checkPhase:

   checkPhase = ''
     export HOME=$TMPDIR
     mv sfepy sfepy.hidden
     mkdir -p $HOME/.matplotlib
     echo "backend: ps" > $HOME/.matplotlib/matplotlibrc
     ${python.interpreter} run_tests.py -o $TMPDIR/test_outputs --raise
   '';

I've added the -o option and kept --raise to help the next person who breaks these tests - otherwise the exact reason for failure requires a bit of digging.

@lheckemann lheckemann added this to the 20.03 milestone Sep 12, 2019
@wd15
Copy link
Contributor Author

wd15 commented Sep 16, 2019

@riscle, ping reminder that I made necessary changes.

Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool - sorry, I don't have merge rights but I can approve at least.

@disassembler disassembler modified the milestones: 20.03, 20.09 Feb 5, 2020
@FRidh FRidh merged commit 74cb7cd into NixOS:master Feb 9, 2020
@wd15 wd15 deleted the sfepy-init branch February 28, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants