Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/opengl: set LD_LIBRARY_PATH everywhere #67791

Merged
merged 1 commit into from Sep 9, 2019
Merged

nixos/opengl: set LD_LIBRARY_PATH everywhere #67791

merged 1 commit into from Sep 9, 2019

Conversation

matthewbauer
Copy link
Member

Unfortunately there are still a few programs that need this. To avoid
breaking too many things for the 19.09 release, I recommend making
this true. We can disable it again once we feel confident most of
these cases are handled. Relevant issues:

/cc @ambrop72 @disassembler @lheckemann

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@matthewbauer
nixos/opengl: set LD_LIBRARY_PATH everywhere
6934870 
Unfortunately there are still a few programs that need this. To avoid
breaking too many things for the 19.09 release, I recommend making
this true. We can disable it again once we feel confident most of
these cases are handled. Relevant issues:

- NixOS#67790
- NixOS#66544
- https://discourse.nixos.org/t/getting-an-error-has-anything-regarding-opengl-in-nixpkgs/3641

/cc @ambrop72 @disassembler @lheckemann
@ivan
Copy link
Member

ivan commented Aug 30, 2019

Maybe this could be applied to just 19.09, so that we can keep finding the remaining breakage in master?

@ambrop72
Copy link
Contributor

ambrop72 commented Aug 31, 2019 •
edited

I agree with ivan, this should go to 19.09 only. There also doesn't seem to be a large number of these issues, and they are generally easy to patch.

@worldofpeace worldofpeace mentioned this pull request Sep 2, 2019
Closed
10 tasks
@lheckemann
Copy link
Member

I'll cherry-pick this to 19.09 after the branch-off (or anyone else is welcome to), so it doesn't need to land in master at all.

@lheckemann lheckemann added this to the 19.09 milestone Sep 6, 2019
@matthewbauer
Copy link
Member Author

Yeah, just realized some release notes may need to be updated as well.

@lheckemann
Copy link
Member

lheckemann commented Sep 6, 2019 •
edited

I'm not sure they need to be, since this is no net change from 19.03 for 19.09? EDIT: didn't realise that the LD_LIBRARY_PATH removal is probably mentioned in the notes.

@matthewbauer matthewbauer changed the base branch from master to release-19.09 September 9, 2019 16:23
@matthewbauer
Copy link
Member Author

No release notes were includeded, so no update is needed. Probably should include them at some point for 20.03 though.

@matthewbauer matthewbauer merged commit 50101ea into NixOS:release-19.09 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewbauer @ivan @ambrop72 @lheckemann