Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes docs after https://github.com/NixOS/nixpkgs/pull/60219 #67710

Closed
wants to merge 1 commit into from
Closed

fixes docs after https://github.com/NixOS/nixpkgs/pull/60219 #67710

wants to merge 1 commit into from

Conversation

ikervagyok
Copy link
Contributor

Things done

added missing xml-closing-tag in release notes

docs build on nixos, rest is still rebuilding.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @arianvp

@arianvp
Copy link
Member

arianvp commented Aug 29, 2019

Thanks so much. Didn't realise I broke the build :) lets get this merge

@worldofpeace
Copy link
Contributor

Superseded by 19a1e15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikervagyok @arianvp @worldofpeace