Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for GHC 8.8.1 #67709

Merged
merged 22 commits into from Sep 2, 2019
Merged

Fixes for GHC 8.8.1 #67709

merged 22 commits into from Sep 2, 2019

Conversation

vaibhavsagar
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@vaibhavsagar vaibhavsagar changed the base branch from master to haskell-updates August 29, 2019 17:05
This was referenced Aug 29, 2019
Closed
Closed
Closed
Closed
Closed
@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.packages.ghc881.foundation haskell.packages.ghc881.socks haskell.packages.ghc881.aeson haskell.packages.ghc881.polyparse haskell.packages.ghc881.cabal-doctest haskell.packages.ghc881.dlist haskell.packages.ghc881.happy haskell.packages.ghc881.attoparsec haskell.packages.ghc881.th-lift haskell.packages.ghc881.th-abstraction haskell.packages.ghc881.unordered-containers haskell.packages.ghc881.haskell-src-exts

cdepillabout
cdepillabout approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the cabal-doctest_1_0_7 thing.

@cdepillabout
Copy link
Member

@GrahamcOfBorg build haskell.packages.ghc881.memory haskell.packages.ghc881.cabal-doctest

@basvandijk basvandijk merged commit 5b50cf2 into NixOS:haskell-updates Sep 2, 2019
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the ghc881-fixes branch September 2, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @cdepillabout @basvandijk