Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsof: 4.91 -> 4.93.2 #67658

Merged
merged 1 commit into from Aug 30, 2019
Merged

lsof: 4.91 -> 4.93.2 #67658

merged 1 commit into from Aug 30, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dezgeg

@ofborg ofborg bot requested a review from dezgeg August 28, 2019 22:40
@jonringer jonringer mentioned this pull request Aug 29, 2019
Merged
10 tasks
jonringer
jonringer approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS (2 packages broken on master)
diff LGTM
executable seems to work

[52 built (5 failed), 1099 copied (6997.6 MiB), 1114.8 MiB DL]
error: build of '/nix/store/1gjpasid24ljx03ryqgbrzgqfdbdihhz-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67658
3 package are marked as broken and were skipped:
python27Packages.nixpart python37Packages.blivet python37Packages.nixpart

2 package failed to build:
python37Packages.dftfit python37Packages.nixpart0

39 package were build:
adafruit-ampy argus ecryptfs enpass gitAndTools.gitAnnex gitAndTools.git-annex-metadata-gui gitless orca lsh lsof magic-wormhole pantheon.elementary-session-settings paperless python27Packages.bitbucket_api python27Packages.blivet python27Packages.magic-wormhole python27Packages.monty python27Packages.nixpart0 python27Packages.pymatgen python27Packages.python-dotenv python27Packages.python-packer python27Packages.sh python27Packages.sumo python27Packages.txtorcon python37Packages.git-annex-adapter python37Packages.lammps-cython python37Packages.monty python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.python-dotenv python37Packages.python-packer python37Packages.sh python37Packages.sumo python37Packages.txtorcon spaceFM tahoe-lafs tgt tor-arm transporter

PR for one of the broken packages located here: #67665

@mmahut
Copy link
Member

mmahut commented Aug 29, 2019

@GrahamcOfBorg build lsof

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

Darwin:

applying patch /nix/store/z8ldknl7n2511d2qixxgxgga0x8iq52y-no-build-info.patch patching file usage.c applying patch /nix/store/9ci7i9agyhbmdkvxcjk5xzjsycjg5cc0-darwin-dfile.patch patching file dialects/darwin/libproc/dfile.c Reversed (or previously applied) patch detected! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file dialects/darwin/libproc/dfile.c.rej builder for '/nix/store/a73fs4k8hx0rm9i6nz21z4mryyc9mnr7-lsof-4.93.2.drv' failed with exit code 1 error: build of '/nix/store/a73fs4k8hx0rm9i6nz21z4mryyc9mnr7-lsof-4.93.2.drv' failed

@averelld
Copy link
Contributor Author

Redundant patch removed.

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build lsof

@mmahut mmahut merged commit d9e7601 into NixOS:master Aug 30, 2019
@averelld averelld deleted the lsof-update branch August 30, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @mmahut @jonringer