Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/displayManager: slimlock fix (#67350) #67751

Closed
wants to merge 2 commits into from
Closed

nixos/displayManager: slimlock fix (#67350) #67751

wants to merge 2 commits into from

Conversation

misuzu
Copy link
Contributor

@misuzu misuzu commented Aug 30, 2019

Motivation for this change

Allow xautolock to lock session using loginctl lock-session and fix slimlock theme.
See #67350 for details

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@misuzu misuzu changed the title slimlock fix (#67350) nixos/displayManager: slimlock fix (#67350) Sep 12, 2019
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/5

@misuzu
nixos/displayManager: allow overriding a list of variables imported t…
b8869ef 
…o user systemd session (stolen from home-manager), added XDG_SESSION_ID to default list of variables.
@misuzu
nixos/displayManager.slim: fix slimlock themes by importing SLIM_THEM…
2a8cfcf 
…ESDIR variables to user systemd session.
@misuzu
Copy link
Contributor Author

misuzu commented Oct 2, 2019

@adisbladis @edolstra @fpletz please take a look at this.

@misuzu misuzu closed this Oct 9, 2019
@misuzu misuzu deleted the slimlock-fix branch October 9, 2019 22:06
@evenbrenden
Copy link
Contributor

@misuzu did you close this because #67350 (comment) was a sufficient fix? I ran into the same issue - loginctl lock-session does not trigger xss-lock when run as a service because XDG_SESSION_ID is not set in the systemctl environment (I suppose idle hint management is broken too). I'd like to keep xss-lock as a service (and all the safety that comes with it) rather than launching it through sessionCommands. This PR does the trick and I also think it's tidy to do it the same way as home-manager does.

Would you consider reopening? Or, alternatively, would you mind if a created a new one based on it?

@misuzu
Copy link
Contributor Author

misuzu commented Jul 24, 2020 •
edited

@evenbrenden slim is no longer in nixpkgs, see #75389

@evenbrenden
Copy link
Contributor

@evenbrenden slim is no longer in nixpkgs, see #75389

I tested with LightDM and it has the same issue.

@misuzu
Copy link
Contributor Author

misuzu commented Jul 24, 2020 •
edited

would you mind if a created a new one based on it?

Sure, go for it

I tested with LightDM and it has the same issue.

#67350 (comment) is still a good option for the time being

EDIT: sorry, attention issues

@evenbrenden evenbrenden mentioned this pull request Jul 24, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@misuzu @nixos-discourse @evenbrenden