Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hexchat: 2.12.4 -> 2.14.2 #67714

Merged
merged 1 commit into from Aug 31, 2019
Merged

hexchat: 2.12.4 -> 2.14.2 #67714

merged 1 commit into from Aug 31, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Aug 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @romildo

@ofborg ofborg bot requested a review from romildo August 29, 2019 18:49
teto
teto approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@teto teto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, worked fine.
I don't know enough about meson to comment the patchPhase though

ivan
ivan approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by connecting to my ZNC with a very large number of channels, I did not see any crashes or regressions

ivan
ivan reviewed Aug 30, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I just noticed that 2.14.2 always dumps core when I close it:

# /run/current-system/sw/bin/hexchat -d $HOME/.config/hexchats/full
Fatal Python error: PyInterpreterState_Delete: remaining subinterpreters

zsh: abort (core dumped)  /run/current-system/sw/bin/hexchat -d $HOME/.config/hexchats/full

Upstream bug is hexchat/hexchat#2237 but maybe this is just something users have to live with until it's fixed upstream?

@teto
Copy link
Member

teto commented Aug 30, 2019

noticed the same bug, I believe it's fine merging.

@averelld
Copy link
Contributor Author

I've added the fedora patch.

ivan
ivan approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again, no core dump on exit any more; LGTM

@ivan
Copy link
Member

ivan commented Aug 30, 2019

@GrahamcOfBorg build hexchat

@disassembler disassembler merged commit 60216e8 into NixOS:master Aug 31, 2019
@averelld averelld deleted the hexchat-upgrade branch August 31, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan ivan ivan approved these changes

@teto teto teto approved these changes

@romildo romildo Awaiting requested review from romildo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@averelld @teto @ivan @disassembler