Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waypipe: init at 0.6.1 #67713

Merged
merged 2 commits into from Aug 31, 2019
Merged

waypipe: init at 0.6.1 #67713

merged 2 commits into from Aug 31, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 29, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Works with weston-terminal and firefox, but e.g. alacritty and qutebrowser don't work yet (qutebrowser might be fixable with environment variables, but I haven't tried it yet).
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@primeos primeos changed the title [WIP] waypipe: init at 0.6.1 waypipe: init at 0.6.1 Aug 29, 2019
@primeos @dywedir
Fix src.repo
9a897d4 
Co-Authored-By: Vladyslav M. <dywedir@gra.red>
@dywedir
Copy link
Member

dywedir commented Aug 31, 2019

Thanks!

@dywedir dywedir merged commit 19c18e1 into NixOS:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir dywedir left review comments

@disassembler disassembler disassembler requested changes

@gilligan gilligan gilligan approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@primeos @dywedir @gilligan @disassembler