Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starship: 0.12.0 -> 0.13.1 #67712

Merged
merged 1 commit into from Aug 30, 2019
Merged

starship: 0.12.0 -> 0.13.1 #67712

merged 1 commit into from Aug 30, 2019

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Aug 29, 2019

Motivation for this change

New release. New features include nix-shell support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nix path-info -S /nix/store/bp3mszps4fwnm6z3kfb5vw2llljrb6r9-starship-0.12.0
/nix/store/bp3mszps4fwnm6z3kfb5vw2llljrb6r9-starship-0.12.0 36270408

nix path-info -S /nix/store/kb99qf3700zdplnv98q23m4yvh3p1gxd-starship-0.13.1
/nix/store/kb99qf3700zdplnv98q23m4yvh3p1gxd-starship-0.13.1 36293928

@aanderse
Copy link
Member

@GrahamcOfBorg build starship

@aanderse
Copy link
Member

Ran locally, everything seemed to work as before. Not sure what support there is for nix-shell as I didn't see any difference. Maybe because I'm using fish as my shell? 🤷‍♂️

@aanderse aanderse merged commit 9c46c35 into NixOS:master Aug 30, 2019
@bbigras bbigras deleted the starship branch August 30, 2019 12:20
@bbigras
Copy link
Contributor Author

bbigras commented Aug 30, 2019 •
edited

It's supposed to look like this:
image

If you are using direnv, check with echo $IN_NIX_SHELL that you are indeed in a nix-shell.

On my side it seems to only work if I eval starship before direnv in my .bashrc. Otherwise direnv doesn't seem to work.

maybe related to starship/starship#264 . I'll test later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @aanderse