Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.blis: 0.2.4 -> 0.4.0, pythonPackages.thinc: 7.0.8 -> 7.1.0 #67716

Merged
merged 3 commits into from
Sep 30, 2019
Merged

pythonPackages.blis: 0.2.4 -> 0.4.0, pythonPackages.thinc: 7.0.8 -> 7.1.0 #67716

merged 3 commits into from
Sep 30, 2019
+9 −7

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Update the blis and thinc dependencies of spaCy. Tested using the en_core_web_sm model

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@danieldk
pythonPackages.blis: 0.2.4 -> 0.4.0
2dc3bf1 
Major changes:

- Update vendored blis to 0.5.1
- Change license to BSD
- Support for read-only numpy arrays
@danieldk
pythonPackages.thinc: 7.0.8 -> 7.1.0
8cf73ee 
Major change: support read-only numpy arrays
@danieldk
python3Packages.spacy: remove blis/thinc upper bounds
0cca857
@danieldk danieldk requested a review from FRidh as a code owner August 29, 2019 18:32
@danieldk
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.spacy

@ofborg ofborg bot requested a review from aborsu August 29, 2019 19:12
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Aug 29, 2019
@aborsu
Copy link
Contributor

aborsu commented Aug 30, 2019

Looks good to me, good job spotting the license issue.

@danieldk danieldk mentioned this pull request Sep 28, 2019
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/63

@risicle
Copy link
Contributor

risicle commented Sep 29, 2019

nix-review (merge checkout mode) happy for me on macos 10.13.

jonringer
jonringer approved these changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
spacy seems to work

[6 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67716
6 package were build:
python27Packages.blis python27Packages.thinc python37Packages.blis python37Packages.spacy python37Packages.textacy python37Packages.thinc

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.blis python27Packages.thinc python37Packages.blis python37Packages.spacy python37Packages.textacy python37Packages.thinc

@jonringer
Copy link
Contributor

builds locally on nixos, builds on ofborg with darwin. LGTM

@jonringer jonringer merged commit e249ee4 into NixOS:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle

@aborsu aborsu

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danieldk @aborsu @nixos-discourse @risicle @jonringer