Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hidapi: 0.8.0-RC1 -> 0.9.0 #67612

Merged
merged 1 commit into from Aug 29, 2019
Merged

hidapi: 0.8.0-RC1 -> 0.9.0 #67612

merged 1 commit into from Aug 29, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

There is now a proper, maintained upstream. Need to run nix-review on this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@markuskowa
Copy link
Member

I am running nix-review on it.

markuskowa
markuskowa approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review proceeds without errors:

17 package were build:
dolphinEmuMaster gen-oath-safe hidapi libretro.dolphin libu2f-host lutris lutris-free monero monero-gui nitrokey-app openhmd openocd pam_u2f yubikey-manager yubikey-manager-qt yubikey-neo-manager yubioath-desktop

@peterhoeg
Copy link
Member Author

Thanks for checking!

@peterhoeg peterhoeg merged commit 5e3334b into NixOS:master Aug 29, 2019
@peterhoeg peterhoeg deleted the u/hidapi branch August 29, 2019 08:37
@peterhoeg peterhoeg restored the u/hidapi branch August 29, 2019 10:12
@peterhoeg peterhoeg deleted the u/hidapi branch September 13, 2019 09:52
@peterhoeg peterhoeg restored the u/hidapi branch September 13, 2019 11:03
@peterhoeg peterhoeg deleted the u/hidapi branch September 24, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterhoeg @markuskowa