Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 07054b42d8c4
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 5e2f89bbce11
Choose a head ref
  • 2 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 27, 2019

  1. nixos/treewide: drop dependencies to keys.target

    The `keys.target` is used to indicate whether all NixOps keys were
    successfully uploaded on an unattended reboot. However this can cause
    startup issues e.g. with NixOS containers (see #67265) and can block
    boots even though this might not be needed (e.g. with a dovecot2
    instance running that doesn't need any of the NixOps keys).
    
    As described in the NixOps manual[1], dependencies to keys should be
    defined like this now:
    
    ``` nix
    {
      systemd.services.myservice = {
        after = [ "secret-key.service" ];
        wants = [ "secret-key.service" ];
      };
    }
    ```
    
    However I'd leave the issue open until it's discussed whether or not to
    keep `keys.target` in `nixpkgs`.
    
    [1] https://nixos.org/nixops/manual/#idm140737322342384
    Ma27 committed Aug 27, 2019
    Copy the full SHA
    56a7bc0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2019

  1. Merge pull request #67394 from Ma27/drop-keys.target-dependency

    nixos/treewide: drop dependencies to `keys.target`
    lheckemann committed Aug 28, 2019
    Copy the full SHA
    5e2f89b View commit details
    Browse the repository at this point in the history