Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evtest-qt: use qt5's mkDerivation #67614

Merged
merged 1 commit into from Aug 28, 2019
Merged

evtest-qt: use qt5's mkDerivation #67614

merged 1 commit into from Aug 28, 2019

Conversation

alexarice
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@alexarice
Copy link
Contributor Author

#65399

@alexarice
Copy link
Contributor Author

@peterhoeg @ttuegel as you both seem to know what's going on with qt apps.

Do either of you know why I can't get this to run with sudo? I get the following error,

sudo result/bin/evtest-qt                   ~/nixpkgs-review
No protocol specified
qt.qpa.xcb: could not connect to display :0
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Available platform plugins are: wayland-egl, wayland, wayland-xcomposite-egl, wayland-xcomposite-glx, minimal, offscreen, vnc, xcb.

[1]    23611 abort      sudo result/bin/evtest-qt

Adding wrapQtAppsHook does not seem to work. The program works fine when not ran through root

@peterhoeg
Copy link
Member

I have no issues with sudo and this PR.

@worldofpeace
Copy link
Contributor

Do you use wayland @alexarice?

@alexarice
Copy link
Contributor Author

Do you use wayland @alexarice?

yes, I thought this could be the problem, can root not connect to wayland?

@worldofpeace
Copy link
Contributor

Do you use wayland @alexarice?

yes, I thought this could be the problem, can root not connect to wayland?

Indeed, I believe that is the cause of your issue.

@alexarice
Copy link
Contributor Author

Do you use wayland @alexarice?

yes, I thought this could be the problem, can root not connect to wayland?

Indeed, I believe that is the cause of your issue.

I've only ever used this to check controller input, and I can see that without root. Is it something that is fixable/ worth trying to fix?

@worldofpeace
Copy link
Contributor

Do you use wayland @alexarice?

yes, I thought this could be the problem, can root not connect to wayland?

Indeed, I believe that is the cause of your issue.

I've only ever used this to check controller input, and I can see that without root. Is it something that is fixable/ worth trying to fix?

I'm pretty sure with wayland it's impossible and un-allowed.

@alexarice
Copy link
Contributor Author

fair enough, the fix in this pr still needs to go through as the program doesn't run at all without it

worldofpeace
worldofpeace approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I verified the binary was wrapped and executed it without a runtime error.

@worldofpeace worldofpeace changed the title evtest-qt: use qt mkDerivation evtest-qt: use qt5's mkDerivation Aug 28, 2019
@worldofpeace worldofpeace merged commit 4ae9d16 into NixOS:master Aug 28, 2019
@alexarice alexarice deleted the evtest-fix branch August 28, 2019 13:00
@alexarice
Copy link
Contributor Author

Thanks for the quick merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexarice @peterhoeg @worldofpeace