Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirage: fix build failure #67765

Merged
merged 1 commit into from Aug 30, 2019
Merged

mirage: fix build failure #67765

merged 1 commit into from Aug 30, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Aug 30, 2019

This adds the missing msgfmt binary from the gettext package to the build PATH.

Motivation for this change

The mirage build is currently failing and not available in 19.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

worldofpeace
worldofpeace approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixes the build for me.

@worldofpeace
Copy link
Contributor

The mirage build is currently failing and not available in 19.03.

I think you mean a prebuilt binary isn't. I can backport this fix.

@worldofpeace worldofpeace merged commit 38c209d into NixOS:master Aug 30, 2019
@worldofpeace
Copy link
Contributor

backported in 88001c7

@B4dM4n B4dM4n deleted the mirage-build branch August 30, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@B4dM4n @worldofpeace @Janik-Haag