Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clightning: 0.7.1 -> 0.7.2.1 #67763

Closed
wants to merge 1 commit into from
Closed

clightning: 0.7.1 -> 0.7.2.1 #67763

wants to merge 1 commit into from

Conversation

jonasnick
Copy link
Contributor

Motivation for this change

New release.

Things done

Checked against signed hash. Also requires new dependency "Mako" as mentioned in the release notes (https://github.com/ElementsProject/lightning/releases/tag/v0.7.2.1).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (ArchLinux)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jb55

@ofborg ofborg bot requested a review from jb55 August 30, 2019 12:52
jb55
jb55 approved these changes Aug 31, 2019
View reviewed changes
Copy link
Contributor

@jb55 jb55 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I've verified the hash matches the one signed by @rustyrussell and @cdecker

@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

@jonasnick do you mind resolving the conflict?

@jb55
Copy link
Contributor

jb55 commented Sep 1, 2019

this needs a bit more work. I'll do a new PR

@jb55 jb55 mentioned this pull request Sep 1, 2019
Merged
10 tasks
@mmahut mmahut closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonasnick @mmahut @jb55