Yubico local auth #67748
Merged
Yubico local auth #67748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Marek Mahut <marek.mahut@gmail.com>
typetetris
force-pushed
the
yubico-local-auth
branch
from
295a9a6
to
edf538f
Compare
ck3d
approved these changes
Sep 23, 2019
|
Looks good! I haven't confirmed it works, but it doesn't look like it'd regress for the non-local case anyway :). Thanks! By the way, do you know a reason to prefer using yubico-pam locally vs pam_u2f ? Not being sure of the trade-offs is at least partially why local wasn't supported earlier. It's a good change regardless, IMO :). FWIW I've been using pam_u2f built against libfido2, I was hoping the software involved would cuta release before sending upstream.... xD. Anyway looks good, let me know if you have thoughts about how they compare but that's not important ;). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Provide a configuration option to use local challenge response authentication with a yubico YubiKey
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dtzWill