Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove empty nix file #67796

Merged
merged 1 commit into from Aug 30, 2019
Merged

remove empty nix file #67796

merged 1 commit into from Aug 30, 2019

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Aug 30, 2019

Nix repl hangs when evaluating empty files.

find -name "*.nix" -empty -delete
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@zimbatm
remove empty nix file
80a3988 
Nix repl hangs when evaluating empty files.

    find -name "*.nix" -empty -delete
@matthewbauer matthewbauer merged commit 7c76c8c into NixOS:master Aug 30, 2019
@zimbatm zimbatm deleted the remove-empty-nix-files branch August 31, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zimbatm @matthewbauer