New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fwupd: 1.2.8 → 1.2.10 #67625
fwupd: 1.2.8 → 1.2.10 #67625
Conversation
Some manual changes were applied on top of that.
Still building the polkit fix. fwupd builds extremely slow while I am also building #67596. |
The issue with the missing PolKit files in the installed tests:
is that fwupd now checks for presence of the polkit actions on the system: The path is obtained from pkg-config: https://github.com/fwupd/fwupd/blob/80e02dfe21068125399b8a8cb5cb870b59ccb58c/meson.build#L166-L170 so we will override it with a environment variable. It will not affect the installation, since https://github.com/fwupd/fwupd/blob/80e02dfe21068125399b8a8cb5cb870b59ccb58c/policy/meson.build#L10 |
https://github.com/fwupd/fwupd/blob/1.2.10/data/org.freedesktop.fwupd.metainfo.xml#L35-L81 * adopt the package * libflashrom is disabled by default since it is experimental now. * add installed tests to passthru for easier running * concretize patchShebags * no changes in filesInstalledToEtc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, it builds for me on NixOS (test included).
Note untested on aarch64, as hydra can't build ghc for it. |
There will be a new release soon so we might want to wait fwupd/fwupd#1320 |
I also packaged gnome-firmware-updater: https://github.com/jtojnar/nixpkgs/tree/gnome-firmware-updater |
Sounds fine by me, we should be sure to have it in the release though. |
You mean the tool is still WIP? I'd say the package could probably be committed, just not a part of any release set or module. |
From the blog post:
|
If you see a need to override this at runtime, can you please send a PR to look for the new variable? Or are you meaning only in the test suite you'll hardcode to a particular location? |
@superm1 we override it at build time. The pkg-config variable works for finding a path to install polkit actions but, due to the way we install global data, polkit needs to look for it in a different path. |
I'm fine waiting, but we may want to go ahead with this if there isn't a new release by Friday. |
Merging as the release still did not happen. |
Reverts #67000
https://github.com/fwupd/fwupd/blob/1.2.10/data/org.freedesktop.fwupd.metainfo.xml#L35-L81