haskell: get cabal-install 3.0.0.0 building on ghc-8.6.5 and ghc-8.8.1 #67624

cdepillabout · 2019-08-28T13:17:00Z

Motivation for this change

Taking a look at hdyra, it appears that cabal-install has recently been updated to 3.0.0.0, but it is failing to build on both GHC-8.6.5 and GHC-8.8.1:

job: https://hydra.nixos.org/eval/1539239
GHC-8.8.1: https://hydra.nixos.org/build/99351396
GHC-8.6.5: https://hydra.nixos.org/build/99458404

This PR tries to fix cabal-install-3.0.0.0 so it builds on both GHC-8.6.5 and GHC-8.8.1.

Here's a summary of why cabal-install-3.0.0.0 doesn't work on both GHCs, and the changes I made in this PR:

GHC-8.6.5:
- cabal-install requires the resolv package. However, the most recent version of resolv (0.1.1.3) requires base-4.13 (GHC-8.8.1). So this PR makes sure a resolve_0_1_1_2 is generated, and then uses that to build cabal-install. (Although, I haven't actually generated hackage-packages.nix, so this code shouldn't work until hackage-packages.nix is regenerated).
GHC-8.8.1:
- cabal-install has an unnecessary dependency on base <= 4.13, so it has been jailbroken.
- the regex-base package needs to be jailbroken (and patched) to work with base-4.13 (GHC-8.8.1), however the build-depend is in a conditional, which it appears jailbreak-cabal can't deal with. So I've had to do this by hand.

I also removed the cabal-install-3 derivation, since it isn't needed anymore.

With these changes, I am now able to build cabal-install:

$ nix-build -A haskell.packages.ghc865.cabal-install
/nix/store/91gdifa89jp99123kkklxakkyl234jxb-cabal-install-3.0.0.0
$ nix-build -A haskell.packages.ghc881.cabal-install
/nix/store/ggz9mffjm73kryx517xyja1xx6hakvv1-cabal-install-3.0.0.0

Things done

Notify maintainers

cc @peti @infinisil

…ts dependencies

…aluation on Hydra

This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@cb6609e.

cdepillabout · 2019-08-28T13:21:13Z

@GrahamcOfBorg build haskell.packages.ghc865.cabal-install

@GrahamcOfBorg build haskell.packages.ghc881.cabal-install

@GrahamcOfBorg build cabal-install

edit: This was dumb. haskell.packages.ghc865.cabal-install won't be able to be built until hackage2nix is run again and the resolv_0_1_1_2 package is generated for us. When that happens, cabal-install should start building again.

You can see that building haskell.packages.ghc881.cabal-install does currently succeed with this PR though, since it uses the latest version of resolv (0.1.1.3).

cdepillabout · 2019-08-28T13:22:56Z

Also, I should mention that I was basically just guessing at the correct files to make changes in, so please let me know if I should be making different changes.

cdepillabout · 2019-08-28T13:28:51Z

pkgs/development/haskell-modules/configuration-ghc-8.8.x.nix

@@ -109,13 +96,21 @@ self: super: {
    url = "https://raw.githubusercontent.com/hvr/head.hackage/master/patches/cabal-doctest-1.0.6.patch";
    sha256 = "0735mkxhv557pgnfvdjakkw9r85l5gy28grdwg929m26ghbf9s8j";
  });
-  QuickCheck = appendPatch super.QuickCheck (pkgs.fetchpatch {


This QuickCheck patch is no longer needed because hackage-packages.nix has a recent version of QuickCheck.

cdepillabout · 2019-08-28T13:29:14Z

pkgs/development/haskell-modules/configuration-ghc-8.8.x.nix

@@ -137,10 +132,6 @@ self: super: {
    url = "https://raw.githubusercontent.com/hvr/head.hackage/master/patches/optparse-applicative-0.14.3.0.patch";
    sha256 = "068sjj98jqiq3h8h03mg4w2pa11q8lxkx2i4lmxivq77xyhlwq3y";
  });
-  HTTP = appendPatch (doJailbreak super.HTTP) (pkgs.fetchpatch {


This patch is no longer needed because hackage-packages.nix has a recent version of HTTP.

cdepillabout · 2019-08-28T13:29:35Z

pkgs/development/haskell-modules/configuration-ghc-8.8.x.nix

@@ -85,18 +84,6 @@ self: super: {
      sed -i -e 's/time < 1.9/time < 2/' tar.cabal
    '';
  });
-  resolv = overrideCabal (overrideSrc super.resolv {


The latest version of resolv now builds with ghc-8.8.1.

cdepillabout · 2019-09-04T20:13:14Z

@peti Is there anything you'd like me to do to help out with this? It looks like there are some conflicts now, so should I try to fix them and rebase this on the current haskell-updates?

peti · 2019-09-04T20:16:29Z

should I try to fix them and rebase this on the current haskell-updates?

Yes, that would be very helpful! Please re-base the PR and ping me one more time. I'll take a lot of the remainder of the changes then. Sorry for the delay!

cdepillabout · 2019-09-07T04:19:46Z

Looks like this is all already building on the current haskell-updates branch, so I'm going to go ahead and close it.

Thanks!

peti and others added 11 commits August 28, 2019 10:09

LTS Haskell 14.3

Verified

This commit was signed with the committer’s verified signature.

delroth Pierre Bourdon

GPG key ID: 6FB80DCD84DA0F1C

Verified
Learn about vigilant mode

d56936a

hackage2nix: keep ghc-lib-parser-8.8.0.20190723 until hlint updates i…

Verified

This commit was signed with the committer’s verified signature.

vcunat Vladimír Čunát

GPG key ID: E747DF1F9575A3AA

Verified
Learn about vigilant mode

ab0a298

…ts dependencies

haskell-dhall-json: disable broken test suite to fix the build

209de88

hackage2nix: unbreak dhall-json build

5c47e17

hackage2nix: disable builds depended on broken packages that break ev…

58c5484

…aluation on Hydra

hackage-packages.nix: automatic Haskell package set update

eea0e2f

This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@cb6609e.

hackage-packages.nix: automatic Haskell package set update

86cf631

This update was generated by hackage2nix v2.14.4-7-ga804c35 from Hackage revision commercialhaskell/all-cabal-hashes@cb6609e.

hackage2nix: Make sure resolv_0_1_1_2 is generated.

c64768b

haskell: get cabal-install-3.0.0.0 building on ghc-8.6.5

a2ebc59

haskell: get cabal-install compiling with ghc-8.8.1.

f88e075

haskell: remove no-longer-necessary cabal-install-3

08f8634

cdepillabout requested a review from basvandijk as a code owner August 28, 2019 13:17

ofborg bot added the 6.topic: haskell label Aug 28, 2019

cdepillabout commented Aug 28, 2019

View reviewed changes

peti force-pushed the haskell-updates branch 6 times, most recently from 367d0eb to 79cfb44 Compare September 3, 2019 07:24

peti force-pushed the haskell-updates branch 3 times, most recently from 3de4c46 to 75388ff Compare September 6, 2019 15:28

cdepillabout closed this Sep 7, 2019

cdepillabout deleted the fix-cabal-install branch September 7, 2019 04:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

haskell: get cabal-install 3.0.0.0 building on ghc-8.6.5 and ghc-8.8.1 #67624

haskell: get cabal-install 3.0.0.0 building on ghc-8.6.5 and ghc-8.8.1 #67624

cdepillabout commented Aug 28, 2019 •

edited

Loading

cdepillabout commented Aug 28, 2019 •

edited

Loading

cdepillabout commented Aug 28, 2019

cdepillabout Aug 28, 2019

cdepillabout Aug 28, 2019

cdepillabout Aug 28, 2019

cdepillabout commented Sep 4, 2019 •

edited

Loading

peti commented Sep 4, 2019

cdepillabout commented Sep 7, 2019

haskell: get cabal-install 3.0.0.0 building on ghc-8.6.5 and ghc-8.8.1 #67624

haskell: get cabal-install 3.0.0.0 building on ghc-8.6.5 and ghc-8.8.1 #67624

Conversation

cdepillabout commented Aug 28, 2019 • edited Loading

Motivation for this change

Things done

Notify maintainers

cdepillabout commented Aug 28, 2019 • edited Loading

cdepillabout commented Aug 28, 2019

cdepillabout Aug 28, 2019

Choose a reason for hiding this comment

cdepillabout Aug 28, 2019

Choose a reason for hiding this comment

cdepillabout Aug 28, 2019

Choose a reason for hiding this comment

cdepillabout commented Sep 4, 2019 • edited Loading

peti commented Sep 4, 2019

cdepillabout commented Sep 7, 2019

cdepillabout commented Aug 28, 2019 •

edited

Loading

cdepillabout commented Aug 28, 2019 •

edited

Loading

cdepillabout commented Sep 4, 2019 •

edited

Loading