Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freecad: fix missing app icon and name when running under Wayland #67732

Merged
merged 1 commit into from Sep 2, 2019
Merged

freecad: fix missing app icon and name when running under Wayland #67732

merged 1 commit into from Sep 2, 2019

Conversation

lightbulbjim
Copy link
Contributor

Motivation for this change

Fixes the problem where the app icon would not show under Gnome/Wayland.

Wayland needs to know the name of the .desktop file to show a dock icon and application name.

See: https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Application_Icon

Tested on Gnome/Wayland with the QT backend forced to Wayland, ie QT_QPA_PLATFORM=wayland. If QT_QPA_PLATFORM is unset (or is set to xcb) it uses XWayland.

The patch has been upstreamed and can be removed once a new release is available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @viric @gebner

@ofborg ofborg bot requested review from viric and gebner August 29, 2019 22:56
@lightbulbjim
freecad: fix missing app icon and name when running under Wayland
58cba19 
Has been upstreamed and should be safe to remove in versions >= 0.19
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build freecad

@worldofpeace worldofpeace merged commit 2baa9e7 into NixOS:master Sep 2, 2019
@worldofpeace
Copy link
Contributor

Thanks for fixing this like this for wayland ✨

@lightbulbjim lightbulbjim deleted the freecad-wayland branch September 2, 2019 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@viric viric Awaiting requested review from viric

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lightbulbjim @worldofpeace