Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.junit-xml: init at 1.8 #67730

Merged
merged 1 commit into from Jan 10, 2020
Merged

Conversation

multun
Copy link
Member

@multun multun commented Aug 29, 2019

Motivation for this change

This is needed to update python-sphinx.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 31, 2019

@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml

@wd15
Copy link
Contributor

wd15 commented Sep 3, 2019

I'm not sure that a95fc80 has the correct message format. Should probably be pythonPackages.junit-xml: init at 1.8. Builds for me though.

Result of nix-review pr 67730 1

2 packages were built:
  • python27Packages.junit-xml
  • python37Packages.junit-xml

@multun multun changed the title python: junit-xml: init at 1.8 pythonPackages.junit-xml: init at 1.8 Sep 3, 2019
@multun
Copy link
Member Author

multun commented Sep 3, 2019

@wd15 fixed, thanks

@multun
Copy link
Member Author

multun commented Sep 9, 2019

@FRidh would you mind having a look ? I'd like this to be merged before I try to land a new version of python-sphinx

@FRidh
Copy link
Member

FRidh commented Sep 9, 2019

I can have a look but I do not intend to submit any newer sphinx until after the 19.09 release.

@FRidh
Copy link
Member

FRidh commented Sep 9, 2019

@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
@rvolosatovs rvolosatovs mentioned this pull request Sep 16, 2019
10 tasks
@rvolosatovs
Copy link
Member

Can we get this merged? It's blocking #68947

@multun
Copy link
Member Author

multun commented Jan 7, 2020

@jonringer thanks for the review!

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
has test 👍

failure is upstream issue

[3 built (1 failed), 4 copied (0.1 MiB), 0.0 MiB DL]
error: build of '/nix/store/d6gcd17brp3cirzwnyp4css0ykql4w92-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67730
1 package failed to build:
python38Packages.junit-xml

2 package built:
python27Packages.junit-xml python37Packages.junit-xml

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.junit-xml python37Packages.junit-xml

@jonringer jonringer merged commit 4a73922 into NixOS:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants