New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.junit-xml: init at 1.8 #67730
Conversation
@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml |
I'm not sure that a95fc80 has the correct message format. Should probably be Result of 2 packages were built:
|
@wd15 fixed, thanks |
@FRidh would you mind having a look ? I'd like this to be merged before I try to land a new version of python-sphinx |
I can have a look but I do not intend to submit any newer sphinx until after the 19.09 release. |
@GrahamcOfBorg build python3.pkgs.junit-xml python2.pkgs.junit-xml |
Can we get this merged? It's blocking #68947 |
4365e52
to
de0aafe
Compare
@jonringer thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commit LGTM
has test 👍
failure is upstream issue
[3 built (1 failed), 4 copied (0.1 MiB), 0.0 MiB DL]
error: build of '/nix/store/d6gcd17brp3cirzwnyp4css0ykql4w92-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/67730
1 package failed to build:
python38Packages.junit-xml
2 package built:
python27Packages.junit-xml python37Packages.junit-xml
@GrahamcOfBorg build python27Packages.junit-xml python37Packages.junit-xml |
Motivation for this change
This is needed to update python-sphinx.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)