Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mplayer: 1.3.0 -> 1.4 #67733

Merged
merged 1 commit into from Sep 3, 2019
Merged

mplayer: 1.3.0 -> 1.4 #67733

merged 1 commit into from Sep 3, 2019

Conversation

averelld
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested a review from edolstra August 29, 2019 23:25
@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build mplayer

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

Failures on aarch64:

vidix/sysdep/AsmMacros_x86.h:258:4: error: impossible constraint in 'asm'

@averelld
Copy link
Contributor Author

Never worked on hydra, I've removed the platform.

@mmahut
Copy link
Member

mmahut commented Aug 30, 2019

@GrahamcOfBorg build mplayer

@aristidb aristidb merged commit ec57a12 into NixOS:master Sep 3, 2019
@averelld averelld deleted the mplayer-upgrade branch September 3, 2019 21:18
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 23, 2019
@averelld @dtzWill
mplayer: 1.3.0 -> 1.4 (NixOS#67733)
08b135b 
(cherry picked from commit ec57a12)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler requested changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@averelld @mmahut @disassembler @aristidb