Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kanshi: 2019-02-02 -> 1.0.0 #67609

Merged
merged 1 commit into from Aug 28, 2019
Merged

kanshi: 2019-02-02 -> 1.0.0 #67609

merged 1 commit into from Aug 28, 2019

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Aug 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @balsoft

@ofborg ofborg bot requested a review from balsoft August 28, 2019 08:57
balsoft
balsoft approved these changes Aug 28, 2019
View reviewed changes
Copy link
Member

@balsoft balsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would also be fair if you added yourself as a maintainer.

@dywedir
Copy link
Member Author

dywedir commented Aug 28, 2019

Will do next time!

@grahamc grahamc merged commit 45b4ab4 into NixOS:master Aug 28, 2019
@dywedir dywedir deleted the kanshi branch August 28, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balsoft balsoft balsoft approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dywedir @balsoft @grahamc