Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 76.0.3809.100 -> 76.0.3809.132 #67610

Merged
merged 1 commit into from Sep 1, 2019
Merged

chromium: 76.0.3809.100 -> 76.0.3809.132 #67610

merged 1 commit into from Sep 1, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Aug 28, 2019 •
edited

Motivation for this change

https://chromereleases.googleblog.com/2019/08/stable-channel-update-for-desktop_26.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On an NVIDIA and a radeon machine:

Built stable and used it for a day, didn't seen any regressions.

Built beta and confirmed that YouTube, audio, WebGL work.

Built dev and confirmed that YouTube, audio, WebGL work.

Notify maintainers

cc @

@ivan ivan mentioned this pull request Aug 28, 2019
Merged
10 tasks
@ivan
Copy link
Member Author

ivan commented Aug 28, 2019

Updated with test results, please merge.

@disassembler disassembler self-requested a review September 1, 2019 02:22
@disassembler disassembler merged commit 0e703ce into NixOS:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ivan @disassembler