Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotestsum: Init at 0.3.5 #67618

Merged
merged 2 commits into from Aug 31, 2019
Merged

gotestsum: Init at 0.3.5 #67618

merged 2 commits into from Aug 31, 2019

Conversation

endocrimes
Copy link
Member

Motivation for this change

Introduce a nix package for gotestsum, a golang test runner that provides both better human friendly output and also machine readable junit xml without having to run tests multiple times. It's fairly new but used heavily by go projects that I interact with.

I'm adding it here rather than keeping it in my personal package repository as it may provide value to others.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit August 28, 2019 12:19
aanderse
aanderse requested changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor things. Looking good though. Thank you!

pkgs/development/tools/gotestsum/default.nix Show resolved Hide resolved
maintainers/maintainer-list.nix Show resolved Hide resolved
@aanderse
Copy link
Member

@GrahamcOfBorg build gotestsum

aanderse
aanderse approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to nixpkgs and adding yourself to the list of maintainers... Welcome to the team! 🎉

@aanderse aanderse merged commit 4c6b09d into NixOS:master Aug 31, 2019
@endocrimes endocrimes deleted the i-gotestsum branch August 31, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@aanderse aanderse aanderse approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@endocrimes @aanderse @kalbasit @jonringer