Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.iapws: init at 1.4 #67620

Merged
merged 1 commit into from Feb 9, 2020
Merged

pythonPackages.iapws: init at 1.4 #67620

merged 1 commit into from Feb 9, 2020

Conversation

dawidsowa
Copy link
Contributor

Motivation for this change

Added iapws

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@dawidsowa dawidsowa requested a review from FRidh as a code owner August 28, 2019 12:38
jonringer
jonringer approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (some nit-picks)
leaf package

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/67620
2 package were build:
python27Packages.iapws python37Packages.iapws

closure size is mostly from scipy, which is huge.

$ nix path-info -Sh ./results/python37Packages.iapws
/nix/store/b88kmkyzjwxl3hpfvh9gr19ljijgmbl9-python3.7-iapws-1.4  215.5M

pkgs/development/python-modules/iapws/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/iapws/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/iapws/default.nix Outdated Show resolved Hide resolved
@FRidh FRidh merged commit 2eeda84 into NixOS:master Feb 9, 2020
@dawidsowa dawidsowa deleted the python-iapws branch October 11, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dawidsowa @jonringer @FRidh