Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-cpp: 0.11.0 -> 0.12.0 #67769

Closed
wants to merge 2 commits into from
Closed

google-cloud-cpp: 0.11.0 -> 0.12.0 #67769

wants to merge 2 commits into from

Conversation

andir
Copy link
Member

@andir andir commented Aug 30, 2019 •
edited

Motivation for this change

My first attempt at updating the package. The packaging gained yet another indirection because they decided to move a few CMake files to another repositorry which in turn also pull down yet another repository of CMake files…

cc @flokli

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@flokli
Copy link
Contributor

flokli commented Aug 30, 2019

I pushed a commit on top which fixes wrapping this package with pkgs.enableDebugging.

Otherwise, (pkgs.enableDebugging pkgs.google-cloud-cpp) would fail like this:

In file included from /build/source/google/cloud/storage/internal/object_streambuf.h:20:0,
                 from /build/source/google/cloud/storage/internal/object_streambuf.cc:15:
/build/source/google/cloud/storage/internal/http_response.h: In constructor 'google::cloud::storage::v1::internal::ObjectWriteStreambuf::ObjectWriteStreambuf(std::unique_ptr<google::cloud::storage::v1::internal::ResumableUploadSession>, std::size_t, std::unique_ptr<google::cloud::storage::v1::internal::HashValidator>)':
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
/build/source/google/cloud/storage/internal/http_response.h: In member function 'google::cloud::v0::StatusOr<google::cloud::storage::v1::internal::HttpResponse> google::cloud::storage::v1::internal::ObjectWriteStreambuf::FlushFinal()':
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
/build/source/google/cloud/storage/internal/http_response.h: In member function 'google::cloud::v0::StatusOr<google::cloud::storage::v1::internal::HttpResponse> google::cloud::storage::v1::internal::ObjectWriteStreambuf::Flush()':
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
/build/source/google/cloud/storage/internal/http_response.h:33:8: error: '*((void*)(&<anonymous>)+40).google::cloud::storage::v1::internal::HttpResponse::status_code' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 struct HttpResponse {
        ^~~~~~~~~~~~
cc1plus: all warnings being treated as errors

flokli added a commit to flokli/nixpkgs that referenced this pull request Oct 5, 2019
@flokli
google-cloud-cpp: 0.11.0 -> 0.14.0
5e225b7 
This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig
for more of the dependencies. On top of that, the installation looks
much better (we don't need to fixup library paths and move files around)

On top of that, upstream introduced another intermediate dependency
(googleapis-cpp-cmakefiles).

Obsoletes NixOS#67769.
@flokli flokli mentioned this pull request Oct 5, 2019
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Oct 5, 2019

Obsoleted by #70485.

@flokli flokli closed this Oct 5, 2019
nbr pushed a commit to BookBub/nixpkgs that referenced this pull request Oct 16, 2019
@flokli @nbr
google-cloud-cpp: 0.11.0 -> 0.14.0
1911997 
This bumps google-cloud-cpp to 0.14.0, which switched to using pkgconfig
for more of the dependencies. On top of that, the installation looks
much better (we don't need to fixup library paths and move files around)

On top of that, upstream introduced another intermediate dependency
(googleapis-cpp-cmakefiles).

Obsoletes NixOS#67769.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @flokli