Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caf: 0.17.1 -> 0.17.2; enable openssl; run tests #67771

Merged
merged 4 commits into from Dec 25, 2019
Merged

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Aug 30, 2019

Motivation for this change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @bobakker

@tobim tobim changed the title caf: run tests and enable openssl support caf: 0.17.1 -> 0.17.2; enable openssl; run tests Oct 21, 2019
@tobim
Copy link
Contributor Author

tobim commented Oct 21, 2019

Rebased and added the version bump.

@marsam marsam merged commit 51a5e62 into NixOS:master Dec 25, 2019
@marsam
Copy link
Contributor

marsam commented Dec 25, 2019

Thank you @tobim, please feel free to ping me if a PR gets stuck

@tobim tobim deleted the pkgs/caf branch December 25, 2019 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants