gitlab: 12.1.6 -> 12.2.3 #67770
Closed
gitlab: 12.1.6 -> 12.2.3 #67770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flokli
added
1.severity: security
9.needs: port to stable
|
@GrahamcOfBorg test gitlab |
|
@GrahamcOfBorg test gitlab |
jonringer
reviewed
Aug 30, 2019
There was a problem hiding this comment.
I think the nixosTest for this may need to be changed somewhat, seems there's an issue with redis:
nixosTests.gitlab logs
gitlab# [ 1737.295028] gitaly[672]: time="2019-08-30T15:43:02Z" level=info msg="\tfrom /nix/store/aqg0yb1d7bckrvppmi3kb4yrl0fwg6a4-gitaly-1.59.2-ruby/bin/gitaly-ruby:8:in `<main>'" supervisor.args="[bundle exec bin/ruby-cd /var/gitlab/state/home /nix/store/aqg0yb1d7bckrvppmi3kb4yrl0fwg6a4-gitaly-1.59.2-ruby/bin/gitaly-ruby 672 /tmp/gitaly-ruby840197256/socket.0]" supervisor.name=gitaly-ruby.0
gitlab# [ 1737.308437] gitaly[672]: time="2019-08-30T15:43:02Z" level=warning msg=exited error="exit status 1" supervisor.args="[bundle exec bin/ruby-cd /var/gitlab/state/home /nix/store/aqg0yb1d7bckrvppmi3kb4yrl0fwg6a4-gitaly-1.59.2-ruby/bin/gitaly-ruby 672 /tmp/gitaly-ruby840197256/socket.0]" supervisor.name=gitaly-ruby.0
gitlab# [ 1737.325162] gitaly[672]: time="2019-08-30T15:43:03Z" level=warning msg=spawned supervisor.args="[bundle exec bin/ruby-cd /var/gitlab/state/home /nix/store/aqg0yb1d7bckrvppmi3kb4yrl0fwg6a4-gitaly-1.59.2-ruby/bin/gitaly-ruby 672 /tmp/gitaly-ruby840197256/socket.0]" supervisor.name=gitaly-ruby.0 supervisor.pid=4393
gitlab# [ 1737.332037] unicorn[1721]: I, [2019-08-30T15:43:03.012863 #1958] INFO -- : Completed 500 Internal Server Error in 93ms (ActiveRecord: 19.6ms)
gitlab# [ 1737.338976] unicorn[1721]: F, [2019-08-30T15:43:03.016814 #1958] FATAL -- :
gitlab# [ 1737.340246] unicorn[1721]: curl: (22) The requested URL returned error: 500 Internal Server Error
gitlab# F, [2019-08-30T15:43:03.016880 #1958] FATAL -- : Redis::CannotConnectError (Error connecting to Redis on localhost:6379 (Errno::ECONNREFUSED)):
gitlab# [ 1737.352113] unicorn[1721]: F, [2019-08-30T15:43:03.016905 #1958] FATAL -- :
gitlab# [ 1737.357206] unicorn[1721]: F, [2019-08-30T15:43:03.016945 #1958] FATAL -- : config/initializers/zz_metrics.rb:204:in `connect'
gitlab# [ 1737.358761] unicorn[1721]: lib/gitlab/anonymous_session.rb:12:in `block in store_session_id_per_ip'
gitlab: exit status 22
(0.52 seconds)
gitlab# [ 1737.360186] unicorn[1721]: lib/gitlab/redis/wrapper.rb:19:in `block in with'
gitlab# [ 1737.363438] unicorn[1721]: lib/gitlab/redis/wrapper.rb:19:in `with'
gitlab# [ 1737.364355] unicorn[1721]: lib/gitlab/anonymous_session.rb:11:in `store_session_id_per_ip'
gitlab# [ 1737.372307] unicorn[1721]: app/controllers/sessions_controller.rb:156:in `store_unauthenticated_sessions'
gitlab# [ 1737.373695] unicorn[1721]: lib/gitlab/session.rb:11:in `with_session'
gitlab# [ 1737.374698] unicorn[1721]: app/controllers/application_controller.rb:450:in `set_session_storage'
gitlab# [ 1737.375931] unicorn[1721]: lib/gitlab/i18n.rb:55:in `with_locale'
gitlab# [ 1737.376900] unicorn[1721]: lib/gitlab/i18n.rb:61:in `with_user_locale'
gitlab# [ 1737.377908] unicorn[1721]: app/controllers/application_controller.rb:444:in `set_locale'
gitlab# [ 1737.379322] unicorn[1721]: lib/gitlab/middleware/rails_queue_duration.rb:27:in `call'
gitlab# [ 1737.381066] unicorn[1721]: lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
gitlab# [ 1737.392593] unicorn[1721]: lib/gitlab/metrics/transaction.rb:57:in `run'
gitlab# [ 1737.417526] unicorn[1721]: lib/gitlab/metrics/rack_middleware.rb:17:in `call'
gitlab# [ 1737.418740] unicorn[1721]: lib/gitlab/middleware/multipart.rb:103:in `call'
gitlab# [ 1737.422671] unicorn[1721]: lib/gitlab/request_profiler/middleware.rb:17:in `call'
gitlab# [ 1737.439977] unicorn[1721]: lib/gitlab/middleware/go.rb:20:in `call'
gitlab# [ 1737.463483] unicorn[1721]: lib/gitlab/etag_caching/middleware.rb:13:in `call'
gitlab# [ 1737.478489] unicorn[1721]: lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
gitlab# [ 1737.479683] unicorn[1721]: lib/gitlab/middleware/correlation_id.rb:15:in `call'
gitlab# [ 1737.481667] unicorn[1721]: lib/gitlab/middleware/read_only/controller.rb:40:in `call'
gitlab# [ 1737.483693] unicorn[1721]: lib/gitlab/middleware/read_only.rb:18:in `call'
gitlab# [ 1737.485630] unicorn[1721]: lib/gitlab/middleware/basic_health_check.rb:25:in `call'
gitlab# [ 1737.499078] unicorn[1721]: lib/gitlab/request_context.rb:26:in `call'
gitlab# [ 1737.520719] unicorn[1721]: lib/gitlab/metrics/requests_rack_middleware.rb:29:in `call'
gitlab# [ 1737.538547] unicorn[1721]: lib/gitlab/middleware/release_env.rb:12:in `call'
gitlab# [ 1737.551596] gitlab-workhorse[674]: gitlab 127.0.0.1 - - [2019/08/30:15:43:03 +0000] "GET /users/sign_in HTTP/1.0" 500 2926 "" "curl/7.65.3" %!f(int64=306)
gitlab# [ 1738.339770] gitaly[672]: time="2019-08-30T15:43:04Z" level=info msg="PID 4381 BUNDLE_GEMFILE=/nix/store/r7kic887qaa3amg1y9s0jrf126s0g1cg-gemfile-and-lockfile/Gemfile" supervisor.args="[bundle exec bin/ruby-cd /var/gitlab/state/home /nix/store/aqg0yb1d7bckrvppmi3kb4yrl0fwg6a4-gitaly-1.59.2-ruby/bin/gitaly-ruby 672 /tmp/gitaly-ruby840197256/socket.1]" supervisor.name=gitaly-ruby.1
(1165.16 seconds)
error: action timed out after -1 seconds at /nix/store/hiwds9rprdwsh5a6jzcgcmp5aal14r0d-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 247, <__ANONIO__> line 81506.
(1739.35 seconds)
action timed out after -1 seconds at /nix/store/hiwds9rprdwsh5a6jzcgcmp5aal14r0d-nixos-test-driver/lib/perl5/site_perl/Machine.pm line 247, <__ANONIO__> line 81506.
cleaning up
killing gitlab (pid 597)
(0.00 seconds)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
builder for '/nix/store/71l3l09pbs1xnr8xs60xr9srf0flnnsa-vm-test-run-gitlab.drv' failed with exit code 255
error: build of '/nix/store/71l3l09pbs1xnr8xs60xr9srf0flnnsa-vm-test-run-gitlab.drv' failed
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 0
and removed
10.rebuild-darwin: 1-10
labels
This was referenced Aug 31, 2019
|
@jonringer I added a PR fixing redis in #67845. Would be great if you could take a look there, too! |
flokli
force-pushed
the
gitlab-12.2.3
branch
from
3193056
to
7c46060
Compare
|
@GrahamcOfBorg test gitlab |
|
@globin there still seems to be something broken in how gitaly's |
|
ping @globin @fpletz @lheckemann |
|
@flokli, isn't |
|
@bgamari I didn't quite look into gitaly - but there's still a |
|
It doesn't build on my NixOS 19.09 server: log |
|
We fixed gitaly - the Also bumped from 12.2.3 to 12.2.5 |
|
@GrahamcOfBorg test gitlab |
flokli
force-pushed
the
gitlab-12.2.3
branch
from
5ed92fd
to
5016560
Compare
|
@test gitlab |
flokli
force-pushed
the
gitlab-12.2.3
branch
from
5016560
to
c7cae30
Compare
|
Ah, it seems this still fails due to https://gitlab.com/groups/gitlab-org/-/epics/802#note_217103588 - we should update the update scripts, locations and derivations… |
|
I have pushed a continuation of this work to #69325. |
|
Thanks, so let's close this here. |
TredwellGit
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://about.gitlab.com/2019/08/29/security-release-gitlab-12-dot-2-dot-3-released/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)